(Re)add support to work with S3 buckets #121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NotTheEvilOne
force-pushed
the
feature/s3-support
branch
2 times, most recently
from
903ac0e to
6ca3cd1
Compare
yeoldegrove
requested changes
Jun 16, 2025
Contributor
yeoldegrove
left a comment
yeoldegrove
left a comment
There was a problem hiding this comment.
Could we have a similar test setup as for the OCI/registry classes?
Spinning up a small s3 server is e.g. possible with https://garagehq.deuxfleurs.fr/documentation/quick-start/.
@NotTheEvilOne Or do you think this is "too much" ?
yeoldegrove
approved these changes
Jun 16, 2025
Contributor
yeoldegrove
left a comment
yeoldegrove
left a comment
There was a problem hiding this comment.
As discussed, tests will be introduced in #122.
Signed-off-by: Tobias Wolf <[email protected]>
NotTheEvilOne
force-pushed
the
feature/s3-support
branch
from
6ca3cd1 to
75e5fba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR (re)adds support for S3 up- and download.
Which issue(s) this PR fixes:
Closes #102